Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix service template generate error in kitex error #217

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

xince-fun
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it (en: English/zh: Chinese):

en: fix service template generate error in kitex error, make it looks better
zh: 修复了一个cwgo 生成kitex service出现的注释换行bug,看起来更美观了

Before fix:

image

After fix:

image

Which issue(s) this PR fixes:

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2024

CLA assistant check
All committers have signed the CLA.

@xince-fun
Copy link
Contributor Author

thrift file from getting-start

# idl/hello.thrift
namespace go hello.example

struct HelloReq {
    1: string Name (api.query="name"); // 添加 api 注解为方便进行参数绑定
}

struct HelloResp {
    1: string RespBody;
}

service HelloService {
    HelloResp HelloMethod(1: HelloReq request) (api.get="/hello");
}

@li-jin-gou li-jin-gou merged commit ba38d82 into cloudwego:main Sep 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants