feat(adk): support skill #661
Conversation
meguminnnnnnnnn
force-pushed
the
feat/wdz/adk_skill
branch
from
274bdde to
feedc21
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #661 +/- ##
==========================================
+ Coverage 80.31% 80.36% +0.04%
==========================================
Files 124 126 +2
Lines 11904 12060 +156
==========================================
+ Hits 9561 9692 +131
- Misses 1613 1621 +8
- Partials 730 747 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
hi team！thanks for ur works. When is this skills feature roughly expected to be merged? This is a promising feature, and we look forward to its integration. |
it maybe released on the end of this week |
meguminnnnnnnnn
force-pushed
the
feat/wdz/adk_skill
branch
5 times, most recently
from
2dec249 to
ca307c3
Compare
| </skills_instructions> | ||
|
|
||
| ` | ||
| skillToolDescriptionTemplate = ` |
There was a problem hiding this comment.
skill 中需要包含 skillPath， skill 的使用，可能会涉及 skillPath 下的 assets、scripts、references 目录
There was a problem hiding this comment.
考虑到模型使用 skill 的场景，下面这俩抽象确实不够。 skill 使用时，可能会需要 read、bash 等工具
| How to invoke: | ||
| - Use this tool with the skill name only (no arguments) | ||
| - Examples: | ||
| - ` + "`" + `skill: "pdf"` + "`" + ` - invoke the pdf skill |
There was a problem hiding this comment.
这地方把 ` 改成 ' 是不是也没啥影响， 这样 Prompt 更易维护一些
There was a problem hiding this comment.
' 里套 " 感觉不好吧
| return "", fmt.Errorf("failed to get skill: %w", err) | ||
| } | ||
|
|
||
| err = validateSkillName(skill.Name) |
There was a problem hiding this comment.
validateSkillName 和 validateSkillContent 不应该在 skill 工具调用时校验，应该在构建时
meguminnnnnnnnn
force-pushed
the
feat/wdz/adk_skill
branch
from
ca307c3 to
52ba06d
Compare
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: