improve: use rustc-hash instead of fxhash for more active support #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukiiiteru
previously approved these changes
Jan 25, 2024
PureWhiteWu
approved these changes
Jan 25, 2024
Millione
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
FxHash is a speedy hash algorithm for use within rustc, and it performs great in hashing integer keys where we use it for. We found that rustc-hash is more active than fxhash crate, so we decided to replace fxhash with rustc-hash.
Solution
Replace fxhash with rustc-hash, and judge the usage of fxhash suitable or not, if not, replace it with ahashmap.