This repository was archived by the owner on Feb 28, 2022. It is now read-only.
Making mechwarrior compatible with Mechanize 2.1 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r us not to break this we need to pass in a native node
Author
|
Note: all Capybara specs pass against both 2.0.1 mechanize and 2.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mechnanize 2.1 performs a sort on an array of form fields in order to ensure that forms are encoded in DOM order, in order for us not to break this we need to pass in a native node. If we don't do this then the sort breaks because all the Form element nodes are Nokogiri::XML::Elements except for ours which is a Capybara::Mechanize::Node.