Chair Shimmy - #13031
Open
kugamo wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
It doesnt make you say anything while shimmying, I just did that on my own for the demo. Just in case someone was worried |
kugamo
marked this pull request as draft
August 26, 2026 14:51
kugamo
marked this pull request as ready for review
August 28, 2026 22:21
kugamo
marked this pull request as draft
August 29, 2026 03:36
IT WAS NECESSARY, CURRENT COMPONENT DOESNT HANDLE THE SCENARIO IN WHICH IT GETS DESTROYED WHILE SHIMMYING MOBS AT ALL 😭
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR lets you shimmy past people seated in immovable chairs..
While occupied movement into the chair tile is blocked in columnar direction, have to move up and down rows.
Occupied dropship seats only block movement from behind, and the back of the seats there anyways
Also I removed an unnecessary variable from chairs, since beds have a similar variable already that can be used.
Explain why it's good for the game
QOL: Makes it easier to find a seat, and adds a bit more organization to dropship seat behavior as well. The shimmying component is neat. :0)
FIX: Currently if an object that shimmies stuff is destroyed shimmied mobs dont have their pixel_x/pixel_y/layers reset back to normal. This PR also fixes that
no ulterior motives
... itd be nice for if perhaps two dropship seats were vertically aligned in a 1 wide room 👀Changelog
🆑 Kugamo
code: removed an unnecessary chair variable
fix: shimmied mobs now get their offsets reset if the object being shimmied around gets destroyed
qol: you can now shimmy past seated people in immovable seats!
/:cl: