Survivors now grant half a larva on permadeath but no extra on burst

[Drulikar]

About the pull request

This PR does the following:

• Survivors now grant 0.5 larva (using a config value) on perma death if they aren't a chestburst and the round_time is under 1 hour
• Survivors no longer can grant extra larva on burst
• Set default config for extra nested bursts to 0.5 to match live server config
• Fixed the issurvivorjob define not accounting for CO survivor
• Fixed chestbursting and gibbing not triggering the undefib signal
• Unified all the different send signals of COMSIG_HUMAN_SET_UNDEFIBBABLE to one helper proc
• Role authority now sets up survivor jobs just based on type rather than hardcoded to 3 different survivor jobs
• Added a survivor spawner to USS runtime just for testing

I wanted to reduce the number of stored_larva based on how many survivors spawned, but if all xeno slots are filled you'd have 0 stored_larva to take away, and being in a stored_larva deficit would be kinda silly. Also survivors aren't in the precount so its not like I can take away xeno slots either and I would rather not change that aspect too.

Explain why it's good for the game

Currently we are seeing survivors have a massive impact on initial xeno population if a majority end up captured. This should make it where whether they get capped or not has less of a variable impact (old range was either 0 or 1.5 larva per survivor on death, now its 0.5 or 1.0 per survivor on death). Also, tying permadeath to additional larva gives more incentive for survivors to actually survive (at least for the first hour) and should punish xenos less for engaging them but failing to capture them.

Testing Photographs and Procedure

Screenshots & Videos

Tested spawning as xeno -> Job is xenomorph (despite faction being survivor) so doesn't use the new survivor logic checking for death so no larva on death (should have chest burst set anyways)

Tested spawning as survivor, getting infected, killed, and embryo expires -> grants death partial larva
Tested spawning as survivor, getting infected, killed, and embryo bursts -> grants no death partial larva
Tested spawning as survivor, getting infected, killed, and embryo is already larva (but not auto bursted yet) when perma'd -> grants no death partial larva
Tested spawning as survivor, getting infected, killed, permas, and embryo incorrectly expires later somehow (extended its TOD check) -> grants death partial larva (enters into grant_larva_on_embryo_delete signal handler)
Tested spawning as survivor, getting infected, killed, permas, and embryo incorrectly matures into larva later somehow (extended its TOD check) -> grants no death partial larva (enters into grant_larva_on_embryo_delete signal handler but early returns on the chestburst check)

Changelog

🆑 Drathek
balance: Survivors no longer grant extra bursts on nested capture but grant 0.5 larva on permadeath (if they didn't chestburst and its within the first hour of the round)
code: Role authority now sets up survivors in a loop based on type rather than hardcoded for each kind of survivor job
code: All previous calls to send COMSIG_HUMAN_SET_UNDEFIBBABLE now utilize a helper proc set_undefibbable instead
config: Default config for nested extra bursts set to the value live has it at
fix: Fixed chestbursting and gibbing not triggering the undefib signal
fix: Fixed the issurvivorjob define not considering a CO survivor job (shouldn't change any behavior since orbit menu would fallback to faction_group)
maptweak: Added a survivor spawner to USS runtime so its possible to spawn as a normal survivor there
/:cl:

[Drulikar]

Possible things I see needing to be done depending:

• Do have survivors in precount (so this technically will make the marine count look larger) but take away a xeno position for every 2?
• Push out the late join marine/xeno ratio more from 15minutes
• Adjust the marine/xeno ratio

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[antlersss]

Code LGTM