Conversation
| @@ -26,7 +26,7 @@ def _launch(config: Config) -> SystemSummary: | |||
| ) as interpreter: | |||
Member
There was a problem hiding this comment.
We could improve this by replacing Interpreter.for_image with Interpreter.for_config. (Alternatively, we could be more OO-friendly by adding an interpreter() method to Config, that produces an interpreter for a given configuration.)
| for fn_launch in config.launches: | ||
| logger.info(f"simulating launch [{fn_launch}]") | ||
| interpreter.launch(fn_launch) | ||
| interpreter.launch(fn_launch, config) |
Member
There was a problem hiding this comment.
If we make the changes above, we wouldn't need to pass config here.
| remappings=remappings, | ||
| args=args) | ||
| args=args, | ||
| config=configuration) |
Member
There was a problem hiding this comment.
We could drop the config parameter if configuration becomes a property of Interpreter.
| namespace: str, | ||
| launch_filename: str, | ||
| remappings: Dict[str, str], | ||
| config: Config, |
| remappings=remappings, | ||
| args='') | ||
| args='', | ||
| config=config) |
| remappings: Dict[str, str], | ||
| args: str | ||
| args: str, | ||
| config: Config |
| launch_filename=launch_filename, | ||
| remappings=remappings) | ||
| remappings=remappings, | ||
| config=config) |
| remappings=remappings, | ||
| manager=mgr) | ||
| manager=mgr, | ||
| config=config) |
ChrisTimperley
requested changes
Sep 22, 2020
ChrisTimperley
left a comment
ChrisTimperley
left a comment
Member
There was a problem hiding this comment.
This looks good, but there's a couple of places where we can clean up pre-existing design limitations to improve quality generally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #104