Skip to content

Fix null pointer dereference in ngram_model_read #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix null pointer dereference in ngram_model_read #438

wants to merge 2 commits into from

Conversation

lenzo-ka
Copy link
Contributor

Description

Fixes a null pointer dereference when reading malformed or empty ARPA language model files.

The NGRAM_ARPA case in ngram_model_read did not check if the model was NULL before proceeding, unlike other file type cases. This caused a crash in ngram_model_apply_weights when processing invalid files.

Changes:

  • Added null check after ngram_model_trie_read_arpa call
  • Returns NULL immediately if model read fails, consistent with other cases

Verification steps

  • Compiled successfully with no errors
  • Prevents NULL pointer dereference crash reported in the issue
  • Matches existing error handling pattern used in NGRAM_BIN case

Fixes #432

@lenzo-ka
Fix stack-buffer overflow in WAV chunk ID logging
5619ada 
Replace unsafe %s format specifier with %c%c%c%c to prevent
reading past the 4-byte non-null-terminated id buffer.

Fixes #431
@lenzo-ka
Fix null pointer dereference in ngram_model_read
5bb7ade 
Add null check for NGRAM_ARPA case to prevent crash when
reading malformed or empty language model files.

Fixes #432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing null check in ngram_model_read for NGRAM_ARPA

1 participant

@lenzo-ka