Fix heap-buffer-overflow in ps_mllr_read #439
Open
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a heap-buffer-overflow that occurs during error cleanup when reading malformed MLLR files.
The issue was caused by missing validation of dimension parameters. When
n_feat
orveclen[i]
contained invalid values (zero, negative, or extremely large),ckd_calloc_3d
would create corrupted array structures. During cleanup,ckd_free_3d
would then read invalid metadata causing a heap-buffer-overflow.Changes:
n_feat
is positive (line 70)veclen[i]
is positive for each feature (line 82)Verification steps
n_class
(line 64)Fixes #433