Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Trivy #4112

Merged
merged 7 commits into from
Nov 10, 2024
Merged

Update Trivy #4112

merged 7 commits into from
Nov 10, 2024

Conversation

itaysk
Copy link
Contributor

@itaysk itaysk commented Nov 3, 2024

was asked to create an new PR instead of #3898

Pre-submission checklist:

Please check each of these after submitting your pull request:

  • Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
  • Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
  • Have you picked the single best (existing) category for your project?
  • Does it follow the other guidelines from the new entries section?
  • Have you added your SVG to hosted_logos and referenced it there?
  • Does your logo clearly state the name of the project/product and follow the other guidelines?
  • Does your project/product name match the text on the logo?
  • Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?

Copy link

github-actions bot commented Nov 3, 2024

You can preview your changes by visiting this link.

Note

This feature is still experimental and may not work as expected in some cases. Please report any issues you find!

landscape.yml Outdated Show resolved Hide resolved
itaysk and others added 3 commits November 6, 2024 16:07
Co-authored-by: Jorge O. Castro <[email protected]>
Signed-off-by: Itay Shakury <[email protected]>
Signed-off-by: Itay Shakury <[email protected]>
@itaysk
Copy link
Contributor Author

itaysk commented Nov 8, 2024

@castrojo I think this is ready? BTW, I'm not sure why trivy-operator was added separately from trivy (it wasn't us who added it). I wouldn't mind removing trivy-operator altogether since IMO it's a module of Trivy

@caniszczyk
Copy link
Contributor

@itaysk if you want to remove the operator please send an updated PR, happy to if this basically is the same as your PR here

@itaysk
Copy link
Contributor Author

itaysk commented Nov 9, 2024

@caniszczyk should I wait for this to be merged and then send another PR or should I just remove it within this PR?

@castrojo castrojo added this pull request to the merge queue Nov 10, 2024
@castrojo
Copy link
Member

@itaysk I'll merge this now, send one to remove it and tag me in it and i'll merge it asap, thanks!

Merged via the queue into cncf:master with commit f093e6a Nov 10, 2024
3 checks passed
@itaysk
Copy link
Contributor Author

itaysk commented Nov 10, 2024

thanks @castrojo , I've created #4126

P.S I said earlier that we (Trivy) didn't add it but I checked and indeed it was added by our team member. Still, I don't see a special reason to have a separate entry for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants