Skip to content

feat: add koffi to allowLargePackages#483

Merged
fengmk2 merged 1 commit intocnpm:masterfrom
LiZhequ:feat/koffi
Feb 2, 2026
Merged

feat: add koffi to allowLargePackages#483
fengmk2 merged 1 commit intocnpm:masterfrom
LiZhequ:feat/koffi

Conversation

@LiZhequ
Copy link
Contributor

@LiZhequ LiZhequ commented Feb 2, 2026

添加白名单申请

请在提交此 Pull Request 之前,确认您已满足以下所有条件:

✅ 必须确认的条件

  • 遵循添加说明:我已经按照 README.md 中的说明正确添加了白名单条目
  • 包类型和使用情况:我添加的 package 是 library(而不是 application),并且有真实的公网用户正在依赖使用。我们不接受为刚创建且没有真实下载流量的 package 添加白名单
  • Scope 要求(如果申请添加 scope):申请添加的 scope 必须已包含热门包(如周下载量超过 1 万)。我们不接受为刚创建且无热门包的 scope 添加白名单

📝 请提供以下信息

添加的包/scope 名称:
koffi

添加原因:
image

使用情况说明(如周下载量、依赖该包的项目等):
image

📋 其他确认

  • 我已使用 CLI 工具添加(推荐),或已确保手动修改的 package.json 格式正确
  • 我理解此 PR 合并后会在 5 分钟内全网生效

感谢您为 unpkg 白名单做出贡献!🎉

Summary by CodeRabbit

  • Chores
    • Updated package dependency configuration to support platform-specific dependencies.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

This PR adds koffi with version "*" to the allowLargePackages configuration in package.json, with some transient node-specific platform entries appearing and then being removed during the change sequence.

Changes

Cohort / File(s) Summary
Package Configuration
package.json
Added koffi to allowLargePackages whitelist. Node-specific platform binary entries were added then removed, with koffi remaining in the final state.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

released

Suggested reviewers

  • fengmk2
  • killagu

Poem

🐰 A coffee called koffi hops on in,
To the whitelist where large packages spin,
Some node friends came and went away,
But koffi stays to brighten the day! ☕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: adding the koffi package to allowLargePackages in package.json.
Description check ✅ Passed The PR description follows the required template structure with all mandatory sections completed, checkboxes filled out, package name specified, and supporting evidence (images) provided.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @LiZhequ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在通过向 unpkg-white-listallowLargePackages 配置添加新包来扩展其功能。此更改允许特定的包被 unpkg 服务,这可能是由于它们的大小或特定要求。它确保这些包能够被 unpkg 服务正确识别和处理,并优化了 package.json 中包列表的结构。

Highlights

  • 新包添加: 将 koffi 包添加到 allowLargePackages 白名单中。
  • 包列表优化: 将多个 node-bin-* 包(如 node-bin-darwin-arm64node-darwin-x64 等)从文件末尾附近移动到 allowLargePackages 列表中的正确字母顺序位置。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 将 koffi 添加到了 allowLargePackages 白名单中。同时,还将之前未排序的 node-* 系列包进行了排序,这很可能是使用 scripts/generate.js 脚本添加 koffi 时自动完成的。整体修改是正确的,保持了 package.json 中列表的有序性,值得合并。

@fengmk2 fengmk2 added this pull request to the merge queue Feb 2, 2026
Merged via the queue into cnpm:master with commit 0e06df5 Feb 2, 2026
7 checks passed
fengmk2 pushed a commit that referenced this pull request Feb 2, 2026
[skip ci]

## 1.249.0 (2026-02-02)

* feat: add koffi to allowLargePackages (#483) ([0e06df5](0e06df5)), closes [#483](#483)
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

🎉 This PR is included in version 1.249.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants