crdb: Add ExecuteCtx for configurable retry limits #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ExecuteCtx which allows configuring maximum retries through context, alongside the existing Execute function. This enables better control over retry behavior while maintaining compatibility with code using the original Execute. The new function helps prevent infinite retry loops in environments where bounded retry counts are required, while preserving the existing error handling and retry semantics.
|
This change is |
Dropping CI for 1.19, 1.20, and 1.21.
sean-
force-pushed
the
add-execute_ctx
branch
from
81016d5 to
c5c9883
Compare
|
Also, FYI re: the reason for the toolchain bumping and limiting the Go support matrix is because various tools were segfaulting on older versions of Go. |
rafiss
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Reviewed 2 of 3 files at r4, 1 of 1 files at r9, 2 of 2 files at r11.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @sean-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ExecuteCtx which allows configuring maximum retries through context, alongside the existing Execute function. This enables better control over retry behavior while maintaining compatibility with code using the original Execute.
The new function helps prevent infinite retry loops in environments where bounded retry counts are required, while preserving the existing error handling and retry semantics.