Skip to content

storage: fix algorithm label for 256-bit V2 encryption keys #160005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BastienClement wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

storage: fix algorithm label for 256-bit V2 encryption keys #160005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/storage/enginepb/key_registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func (e EncryptionType) JWKAlgorithm() (string, error) {
case EncryptionType_AES_192_CTR_V2:
return "cockroach-aes-192-ctr-v2", nil
case EncryptionType_AES_256_CTR_V2:
return "cockroach-aes-192-ctr-v2", nil
return "cockroach-aes-256-ctr-v2", nil
Comment on lines 24 to +25
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JWKAlgorithm function lacks test coverage. Consider adding tests that verify all encryption types return the correct algorithm strings, especially to prevent similar copy-paste errors in the future. A simple table-driven test that checks both JWKAlgorithm and EncryptionTypeFromJWKAlgorithm for all encryption types would help catch issues like this bug.

Copilot uses AI. Check for mistakes.
}
return "", fmt.Errorf("unknown EncryptionType %d", e)
}
Expand Down
Loading