workload/tpccmultidb: restore execution order across databases #160010
+19
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when reducing deadlocks during table object creation and import, we inadvertently changed the execution order of transaction preamble queries. This caused databases and schemas to be sampled in a round-robin fashion rather than the original linear fashion. This patch restores the original execution order so that we have comparable results to previous benchmark runs. Fixes: cockroachdb#159008 Release note: None
Member
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when reducing deadlocks during table object creation and import, we inadvertently changed the execution order of transaction preamble queries. This caused databases and schemas to be sampled in a round-robin fashion rather than the original linear fashion.
This patch restores the original execution order so that we have comparable results to previous benchmark runs.
Fixes: #159008
Release note: None