Skip to content

Conversation

@angeladietz
Copy link
Contributor

Backport 1/1 commits from #158472.

/cc @cockroachdb/release


This adds a new cluster setting
kv.concurrency.slow_latch_request_duration which configures the threshold for logging slow latch acquisitions. Previously, logging would occur after 15 seconds, but now the default is reduced to 5s.

Informs #154271
Release note: None
Epic: None
Part of: CRDB-54843

Release justification: low risk obs improvement to help debug slow latch requests

@blathers-crl
Copy link

blathers-crl bot commented Dec 22, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-kv KV Team labels Dec 22, 2025
@blathers-crl
Copy link

blathers-crl bot commented Dec 22, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl
Copy link

blathers-crl bot commented Dec 22, 2025

❌ PR #160035 does not comply with backport policy

Confidence: high
Explanation: The PR introduces a new cluster setting kv.concurrency.slow_latch_request_duration to adjust the threshold for logging slow latch acquisitions, which has been set to a default of 5 seconds. However, a cluster setting by itself, especially when disabled by default (which is not explicitly confirmed in the PR), does not necessarily gate a new feature. Since the cluster setting appears to modify existing behavior rather than introducing a new feature, and the fix does not directly address stability, security, data corruption, performance regression, incorrect results, or debugging production issues, this PR does not meet the critical bug criteria nor does it conform to the feature flag requirement. Additionally, the 'low risk' release justification does not fit any criteria in the policy for an exception. There is no indication this change marks a breaking backward compatibility issue.
Recommendation: Reconsider the backport as it does not meet critical bug fix criteria and is not gated behind a disabled feature flag. Alternatively, provide stronger justification for why this change is critical and should be backported without a feature flag.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This adds a new cluster setting
kv.concurrency.slow_latch_request_duration which configures the
threshold for logging slow latch acquisitions. Previously, logging would
occur after 15 seconds, but now the default is reduced to 5s.

Informs cockroachdb#154271
Release note: None
Epic: None
Part of: CRDB-54843
@angeladietz angeladietz marked this pull request as ready for review December 23, 2025 20:56
@angeladietz angeladietz requested a review from a team as a code owner December 23, 2025 20:56
@angeladietz angeladietz requested review from arulajmani and removed request for a team December 23, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches T-kv KV Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants