release-26.1: rowexec: add cancel checking to inverted joiner #160038
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just saw a test failure where the stmt didn't respect the statement timeout. The goroutine dump showed that we were evaluating a geo inverted expression in the inverted joiner "read" phase, so this commit adds the cancel checking on each 16th input row (note that this is higher frequency than elsewhere in the row-by-row engine where we check every 128 rows since geo evaluations could be more time-consuming). Note that we could've gone deeper and added the cancellation checks into the geo evaluation functions themselves, but it's not clear whether that's needed. Release note: None
yuzefovich
force-pushed
the
blathers/backport-release-26.1-159946
branch
from
f41c7ec to
88f4a5e
Compare
blathers-crl
bot
added
blathers-backport
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
backport
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #159946 on behalf of @yuzefovich.
We just saw a test failure where the stmt didn't respect the statement timeout. The goroutine dump showed that we were evaluating a geo inverted expression in the inverted joiner "read" phase, so this commit adds the cancel checking on each 16th input row (note that this is higher frequency than elsewhere in the row-by-row engine where we check every 128 rows since geo evaluations could be more time-consuming). Note that we could've gone deeper and added the cancellation checks into the geo evaluation functions themselves, but it's not clear whether that's needed.
Fixes: #159671.
Release note: None
Release justification: low-risk bug fix.