server: init external storage before SQL start #160040
Open
+20
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQL start registers in liveness and invites distSQL flows to be scheduled, which may expect initialized, ready external storage. As such, init external storage before SQL start. External storage can end up coming back and wanting to run SQL (for userfile) so this remains somewhat circular, but given a SQL flow or job or query is what would end up actually opening storage, this ordering seems less fraught than starting SQL first. Release note: none. Epic: none. Unclear if this will fix all cases of observed errors here since we don't have a reproduction or failing test, so this is more of just an optimistic cleanup related to, but not yet known to close, cockroachdb#120022.
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Member
|
Noting for context is this comment from Steven from a while back. |
yuzefovich
reviewed
Dec 23, 2025
Member
yuzefovich
left a comment
yuzefovich
left a comment
There was a problem hiding this comment.
Sounds reasonable to me, should we also apply the same change to SQLServerWrapper.PreStart for tenants?
@yuzefovich made 1 comment.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @msbutler and @stevendanna).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL start registers in liveness and invites distSQL flows to be scheduled, which may expect initialized, ready external storage. As such, init external storage before SQL start.
External storage can end up coming back and wanting to run SQL (for userfile) so this remains somewhat circular, but given a SQL flow or job or query is what would end up actually opening storage, this ordering seems less fraught than starting SQL first.
Release note: none.
Epic: none.
Unclear if this will fix all cases of observed errors here since we don't have a reproduction or failing test, so this is more of just an optimistic cleanup related to, but not yet known to close, #120022.