Fix reflection of JSONB columns #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gordthompson - I have one more. This one was a bit trickier for me to wrap my head around. But under the hood all JSON columns are really JSONB. I didn't change the reflection of JSON, but i don't think it'll ever kick in. JSONB reflects to JSONB. This is important because the rest of the dialect does SQL generation differently for JSONB vs JSON (for example, when using |
|
@nvachhar - Can you please resolve the merge conflict (in CHANGES.md) between your local branch an the updated master branch? |
Done. |
|
@nvachhar - Thanks for your contributions! |
|
My pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.