feat(adb_client): add remount and verity commands #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomaticIT
force-pushed
the
@feat/remount-verity
branch
4 times, most recently
from
7e49387 to
6b7a397
Compare
Owner
|
Hey ! Apart from that I haven't seen anything else, I need to take time to test it before merging :) |
SomaticIT
commented
Dec 16, 2025
| impl RemountInfo { | ||
| pub(crate) fn from_str(s: &str) -> Result<Self> { | ||
| let parts: Vec<&str> = s.split_whitespace().collect(); | ||
| if parts.len() == 4 && parts[0] == "Using" && parts[2] == "for" { |
Contributor
Author
There was a problem hiding this comment.
Is it here?
I'm not sure about how to implement this in a more rusty way.
Any suggestion?
cocool97
force-pushed
the
@feat/remount-verity
branch
from
54bdb85 to
266565d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR introduces 3 new methods:
remount() -> Result<Vec<RemountInfo>>: Remount the device partitions as read-writedisable_verity() -> Result<()>: Disable verity on the deviceenable_verity() -> Result<()>: Enable verity on the deviceon following structs:
ADBTcpDeviceADBUSBDeviceADBServerDevice(i did not have the opportunity to test this one)This PR partially fixes #109, it still misses support for
adb root.I did not found a correct way to apply the root command when looking at the source code of adb. Any idea?
Does this implementation match your guidelines?
Thanks,