Skip to content

Conversation

@nurpabuccu
Copy link

Add adb root command
Add optional 'user' parameter to uninstall command
Add connect/disconnect device with device id, add to pyadb

@cocool97 cocool97 force-pushed the pyadb-root-connect-uninstall branch from fb905b9 to 50e04ae Compare January 10, 2026 17:33
@cocool97 cocool97 force-pushed the pyadb-root-connect-uninstall branch from 4d5be6b to 2cf8f08 Compare January 10, 2026 17:44
@cocool97
Copy link
Owner

Thanks for your PR ! I've pushed a few changes but it looks good to me :)

I still have some questions / requests before merging it:

  • Is root: command also applicable to message devices like ADBUSBDevice ? If yes, can you rather add the method to the ADBDeviceExt trait so that every kind of device can have it?
  • Can you add the root subcommand to adb_cli ?
  • Is user parameter also supported for install commands ? If yes, can you also add to the method parameters ?

@nurpabuccu
Copy link
Author

All the answers are yes. I will work on these updates, thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants