Skip to content

fix crash if JS land raised an unhandled promise rejection #19021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v3.8.8
Choose a base branch
from
Open

fix crash if JS land raised an unhandled promise rejection #19021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions native/cocos/bindings/jswrapper/v8/ScriptEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,11 +1184,12 @@ void ScriptEngine::removeUnhandledPromise(v8::Local<v8::Promise> promise) {
// Remove handled promises from the list
SE_ASSERT(promise->GetIsolate() == _isolate, "Wrong isolate");
auto *isolate = promise->GetIsolate();
for (auto it = _unhandledPromises.begin(); it != _unhandledPromises.end(); ++it) {
v8::Local<v8::Promise> const unhandledPromise = std::get<0>(*it).Get(isolate);
if (unhandledPromise == promise) {
_unhandledPromises.erase(it--);
Copy link
Contributor Author

@shrinktofit shrinktofit Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This crashes if it == _handledPromises.begin()

}
auto const it = std::find_if(_unhandledPromises.begin(), _unhandledPromises.end(), [&](auto const &p) {
v8::Local<v8::Promise> const unhandledPromise = std::get<0>(p).Get(isolate);
return unhandledPromise == promise;
});
if (it != _unhandledPromises.end()) {
_unhandledPromises.erase(it);
}
}

Expand Down
Loading