Skip to content

fix(custom-pipeline) addLight() func, return byte offset error#167

Merged
star-e merged 1 commit into
cocos:v4.0.0from
troublemaker52025:fix(custom-pipeline)-addLight-func-return-byte-offset-error
Jun 26, 2026
Merged

fix(custom-pipeline) addLight() func, return byte offset error#167
star-e merged 1 commit into
cocos:v4.0.0from
troublemaker52025:fix(custom-pipeline)-addLight-func-return-byte-offset-error

Conversation

@troublemaker52025

@troublemaker52025 troublemaker52025 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@troublemaker52025

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@github-actions

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1014459 bytes 1014459 bytes ✅ 0 bytes
2D All (legacy pipeline) 2681984 bytes 2681984 bytes ✅ 0 bytes
2D All (new pipeline) 2773753 bytes 2773761 bytes ⚠️ +8 bytes
(2D + 3D) All 10030969 bytes 10030977 bytes ⚠️ +8 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16867382 bytes 16867390 bytes ⚠️ +8 bytes

Interface Check Report

This pull request does not change any public interfaces !

@github-actions

Copy link
Copy Markdown

@troublemaker52025, Please check the result of run test cases:

Task Details

@github-actions

Copy link
Copy Markdown

@troublemaker52025, Please check the result of run test cases:

Task Details

@star-e
star-e merged commit 07f2c5f into cocos:v4.0.0 Jun 26, 2026
15 checks passed
@github-actions

Copy link
Copy Markdown

@troublemaker52025 ❗ There was an error during the execution of the tasks. Please check the logs for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants