fix(minigame): refactor LRU cache cleanup in cache-manager#171
Open
qiuguohua wants to merge 2 commits into
Open
fix(minigame): refactor LRU cache cleanup in cache-manager#171qiuguohua wants to merge 2 commits into
qiuguohua wants to merge 2 commits into
Conversation
- Change cache eviction ratio from 1/3 to 1/2 - Extract _deleteLRUCaches() for concurrent deletion with callbacks - Add onComplete callback to _removePathOrFile for deletion tracking - Add LOG_PREFIX logging for init and LRU deletion lifecycle
Contributor
Author
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
star-e
reviewed
Jun 29, 2026
| console.warn(`${LOG_PREFIX} init storage`, { | ||
| cacheDir: this.cacheDir, | ||
| cacheFilePath, | ||
| }); |
Contributor
There was a problem hiding this comment.
Shall we change warn to debug?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: