Fix memory leaks in Spine resource parsing on the web-side.#65
Merged
star-e merged 3 commits intococos:v4.0.0from Feb 3, 2026
Merged
Fix memory leaks in Spine resource parsing on the web-side.#65star-e merged 3 commits intococos:v4.0.0from
star-e merged 3 commits intococos:v4.0.0from
Conversation
Closed
star-e
reviewed
Feb 2, 2026
| SkeletonData* SpineWasmUtil::createSpineSkeletonDataWithJson(const String& jsonStr, const String& altasStr, const spine::Vector<spine::String>& textureNames, const spine::Vector<spine::String>& textureUUIDs) { | ||
| SkeletonData* skeletonData = nullptr; | ||
| #if ENABLE_JSON_PARSER | ||
| auto* atlas = new Atlas(altasStr.buffer(), altasStr.length(), "", nullptr, false); |
Contributor
There was a problem hiding this comment.
Shall we use std::unique_ptr<Atlas> ?
Contributor
Author
There was a problem hiding this comment.
Smart pointers may increase the size of WASM binary files.
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
|
@bofeng-song ❗ There was an error during the execution of the tasks. Please check the logs for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: