1.基于 Box2D JSB 的2D物理系统 结束碰撞但不回调 2.回调个数BeginContact和EndContact不一致。#89
Merged
star-e merged 3 commits intococos:v4.0.0from Mar 11, 2026
Merged
1.基于 Box2D JSB 的2D物理系统 结束碰撞但不回调 2.回调个数BeginContact和EndContact不一致。#89star-e merged 3 commits intococos:v4.0.0from
star-e merged 3 commits intococos:v4.0.0from
Conversation
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
bofeng-song
reviewed
Mar 9, 2026
| contactMap.delete(b2contact); | ||
| } | ||
|
|
||
| static clear (): void { |
Contributor
There was a problem hiding this comment.
Where is the clear API called?
Contributor
Author
There was a problem hiding this comment.
clear function left, but there is no better way to call it. because the box2d system follow the engine utils it destroy.
bofeng-song
reviewed
Mar 9, 2026
| c.emit(Contact2DType.END_CONTACT); | ||
|
|
||
| PhysicsContact.put(b2contact); | ||
| PhysicsContactManager.put(b2contact); |
Contributor
There was a problem hiding this comment.
When to clear b2contact？
star-e
approved these changes
Mar 11, 2026
|
@tangkaikk ❗ There was an error during the execution of the tasks. Please check the logs for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: