Skip to content

Commit

Permalink
fixed a bug where recording a second time the blue stop bar up top wo…
Browse files Browse the repository at this point in the history
…uld not appear. cleaning up meta data for tagging and release
  • Loading branch information
code-matt committed Sep 17, 2018
1 parent 4eb0c2b commit 74994f3
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 52 deletions.
2 changes: 2 additions & 0 deletions ios/RNReactNativeReplaykit.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// Created by Matt Thompson on 9/14/18.
// MIT Licence.

#if __has_include("RCTBridgeModule.h")
#import "RCTBridgeModule.h"
Expand Down
3 changes: 2 additions & 1 deletion ios/RNReactNativeReplaykit.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
// Created by Matt Thompson on 9/14/18.
// MIT Licence.

#import "RNReactNativeReplaykit.h"
#import <React/RCTLog.h>
//#import <AVAssetWriter>

#import "RNReactNativeReplaykit-Swift.h"

Expand Down
8 changes: 2 additions & 6 deletions ios/ScreenRecord/FileUtil.swift
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
//
// FileManager.swift
// BugReporterTest
//
// Created by Giridhar on 20/06/17.
// Copyright © 2017 Giridhar. All rights reserved.
// MIT Licence.
// Modified By: [
// Matt Thompson 9/2018
// Matt Thompson 9/14/18
//]


Expand Down
34 changes: 2 additions & 32 deletions ios/ScreenRecord/ScreenRecordCoordinator.swift
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
//
// ScreenRecordCoordinator.swift
// BugReporterTest
//
// Created by Giridhar on 21/06/17.
// Copyright © 2017 Giridhar. All rights reserved.
// MIT Licence.
// Modified By: [
// Matt Thompson 9/2018
// Matt Thompson 9/14/18
//]

import Foundation
Expand Down Expand Up @@ -115,29 +111,3 @@ extension UIApplication {
return base
}
}


//extension FileManager {
// func replaceWithCopyOfFile(at:URL, with:URL) {
// do {
// let url = try self.url(for: .itemReplacementDirectory, in: .userDomainMask, appropriateFor: with.deletingPathExtension(), create: true)
// try self.copyItem(at: with, to: url.appendingPathComponent(with.lastPathComponent))
//
// let alert = NSAlert()
// alert.messageText = "Replace \"\(at.lastPathComponent)\" in \"\(at.pathComponents[at.pathComponents.count - 2])\" with new file?"
// alert.addButton(withTitle: "OK")
// alert.addButton(withTitle: "Cancel")
//
// if alert.runModal() == NSAlertFirstButtonReturn {
// _ = try FileManager.default.replaceItemAt(at, withItemAt: url.appendingPathComponent(with.lastPathComponent))
// }
//
// // removes whole temporary directory as a clean up
// try self.removeItem(at: url)
// }
// catch {
// // error
// print("unknown error")
// }
// }
//}
8 changes: 2 additions & 6 deletions ios/ScreenRecord/ScreenRecorder.swift
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
//
// ScreenRecorder.swift
// BugReporterTest
//
// Created by Giridhar on 09/06/17.
// Copyright © 2017 Giridhar. All rights reserved.
// MIT Licence.
// Modified By: [
// Matt Thompson 9/2018
// Matt Thompson 9/14/18
//]

import Foundation
Expand Down
9 changes: 3 additions & 6 deletions ios/ScreenRecord/WindowUtil.swift
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
//
// WindowUtil.swift
// BugReporterTest
//
// Created by Giridhar on 21/06/17.
// Copyright © 2017 Giridhar. All rights reserved.
// MIT Licence.
// Modified By: [
// Matt Thompson 9/2018
// Matt Thompson 9/14/18
//]

import Foundation
Expand Down Expand Up @@ -78,6 +74,7 @@ class WindowUtil: Overlayable
func show()
{
DispatchQueue.main.async {
self.stopButton.isHidden = false
self.stopButton.transform = CGAffineTransform(translationX: 0, y: -30)
self.stopButton.backgroundColor = self.stopButtonColor
self.overlayWindow.makeKeyAndVisible()
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-replaykit",
"version": "1.0.5",
"version": "1.0.6",
"description": "A React Native module to access ReplayKit Screen Recording Framework on iOS",
"main": "index.js",
"license" : "MIT",
Expand Down

0 comments on commit 74994f3

Please sign in to comment.