Created the backend, as well as connected the form#15
Conversation
as the title sates,doing this for secure ifttt keys.Also, git ignored node modules in the backend
Simply needs some testing using curl
Made a keys.json to be parsed by the backend before deploying :)
Added support for submitting to slack and google sheets, and seems to be working well!
Simply need some slight hlp with api's, and need to be a bit more awake, tested this working slightly
Currently have ifttt and slack working, need to response with our post response however
Made seperate routes for every command, and works with a test org
As the title states
As the title states, the backend now returns nice and understandable slack responses
…ttps://github.com/codeandcoffeelb/signup into enhancement/#7-use-the-slack-api-to-onboard-members
As the title states, simply need to finish the github responses
@davidnuon shreked my computer with concentrated coffe spray, cant finish this branch for now :'( :'( Y U DO DIS??!?!?! I CRIE EVERYTIM
Working great!
Started to do so, and was testing successful responses with ifttt
by requested by @davidnuon
Such as github user names for our requests and things
Tested working with ifttt and slack, simply need to work out some more github weirdness
|
Still reviewing the code, I can see one change that can be done. Please turn the coffee cup into an image. Other than that, looking good so far!
|
|
|
||
| /* GET home page. */ | ||
| router.get('/', function(req, res, next) { | ||
| res.render('index', { title: 'I am a Hamburger' }); |
There was a problem hiding this comment.
What does that mean? Like I said I am a terrible backend guy, so any advice on what I did wrong would be cool! :)
There was a problem hiding this comment.
I think he's just cracking up at the throwaway response to someone accessing /
Personally, I like returning HTTP 418 in this scenario :)
There was a problem hiding this comment.
OHHHHHHH I forgot I put that in there. Yeah julian and I have a joke, similar to googl'es teapot:
And we can definitely add a return of 418 haha
|
Another kink in the animation in Chrome on OSX |
I fixed bugs that the awesome @davidnuon helped me find, Also, made some really good transparent code and coffee logos, as well as some that are not transparent. Lastly, also did some animation work with the divs on mobile, which were calling some functions to fast, so I slowed the timeouts, as well as set a slightly larger height on load, to keep users from having completely broken pages.
|
I made your changes, thank you for the help! @davidnuon |
|
And it is quite weird OSX chrome was behaving like this, I tested on my chrome in linux, and on android and had no problems... |
|
All good :) |
…ack-api-to-onboard-members Created the backend, as well as connected the form
3 participants
closes #7
may close the issue #8
may close the issue #13
Firstly, let me apologize for closing multiple issues in one branch, the other two issues need some more testing, and could be confirmed by anyone willing to serve up the site and test things out :)
I created a little node.js backend to ping some services for us (Such as ifttt for google sheets, an undocumented slack api endpoint to auto invite emails, and the github api to automate org invintes), that we can access from our frontend form, using a little AngularJS service. This was tested working well (Would be nice to do some additional testing however).
This also does some various frontend design improvements, and a lot of them were mentioned by @davidnuon in #13 , and this fixes a lot of those. They mostly dealt with responsiveness, but any additional testing, and confirmation would be nice to confirm closing the issue.
Screenshot (Chrome Inspected Nexus 5x):
P.S this does contain some testing code, such as localhost backend urls and things, that i left in, simply for easier testing by anyone wanting to check this out. Please let me know if this a problem, and I can remove it