This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
[Snyk] Fix for 4 vulnerable dependencies #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chat bot oversampling 'build night'. Regex improved to respond to specific question, to avoid spamming chatroom
bot returns location, logical to respond to where questions along with when
Prior commits fired bot on 'where' or 'when' only, without 'build night' specified in the message. Grouped expressions and added word boundries
Skip jobs channel per chatroom request Found object properties from: https://github.com/slackapi/hubot-slack/blob/1c49569b52b7774e07e158f4909b3a8e3a3a72c2/test/message.coffee\#L31
No Buildnight
Switched from blacklist to whitelist per admin request. Use const in script global scope for high visibility. Specific name and limited to this script. Used indexOf for lookup, reference below: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/indexOf
Buildnight Channels -- Implementation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/npm:ws:20160104 - https://snyk.io/vuln/npm:ws:20160624 - https://snyk.io/vuln/npm:ws:20160920 The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/npm:ms:20170412 - https://snyk.io/vuln/npm:negotiator:20160616 Latest report for codeandsupply/supplybot: https://snyk.io/test/github/codeandsupply/supplybot
The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/npm:debug:20170905 Latest report for codeandsupply/supplybot: https://snyk.io/test/github/codeandsupply/supplybot
[Snyk Update] New fixes for 11 vulnerable dependency paths
[Snyk] Fix for 20 vulnerable dependency paths
The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/npm:hoek:20180212
[Snyk] Fix for 1 vulnerable dependencies
The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/npm:lodash:20180130
[Snyk] Fix for 1 vulnerable dependencies
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/npm:fresh:20170908 - https://snyk.io/vuln/npm:mime:20170907 - https://snyk.io/vuln/npm:ms:20170412 - https://snyk.io/vuln/npm:qs:20170213
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes one or more vulnerable packages in the
npmdependencies of this project.See the Snyk test report for more details.
Snyk Project: codeandsupply/supplybot:package.json
Snyk Organization: colindean
Changes included in this PR
Vulnerabilities that will be fixed
With an upgrade:
Note that some vulnerabilities couldn’t be fully fixed, and so will still fail the Snyk test report.
You can read more about Snyk's upgrade and patch logic in Snyk's documentation.
Check the changes in this PR to ensure they won't cause issues with your project.
Stay secure,
The Snyk team
Note: You are seeing this because you or someone else with access to this repository has authorised Snyk to open Fix PRs. To review the settings for this Snyk project please go to the project settings page.