Skip to content

checkbox checked prop AND not binding to elements without name attr #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

checkbox checked prop AND not binding to elements without name attr #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edde70d
update rails v to latest
jotto Aug 10, 2011
289516b
this includes the checkbox prop changes from my last pull request, an…
jotto Aug 21, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backbone-rails.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Gem::Specification.new do |s|
s.description = "Quickly setup backbone.js for use with rails 3.1. Generators are provided to quickly get started."
s.files = Dir["lib/**/*"] + Dir["vendor/**/*"] + ["MIT-LICENSE", "Rakefile", "README.md"]

s.add_dependency('rails', '~> 3.1.0.rc5')
s.add_dependency('rails', '~> 3.0.10.rc1')
s.add_dependency('coffee-script', '~> 2.2.0')
s.add_dependency('ejs', '~> 1.0.0')

Expand Down
33 changes: 22 additions & 11 deletions vendor/assets/javascripts/backbone_datalink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,28 @@
var el, name;
el = $(this);
name = el.attr("name");
model.bind("change:" + name, function() {
return el.val(model.get(name));
});
return $(this).bind("change", function() {
var attrs;
el = $(this);
attrs = {};
attrs[el.attr("name")] = el.val();
return model.set(attrs);
});

if(typeof name !== "undefined" && name !== null) {
model.bind("change:" + name, function() {
val = model.get(name)
if ( el.is("input[type='checkbox']") && (val == true || val == false) )
el.prop('checked', val);
return el.val(val);
});

return $(this).bind("change", function() {
var attrs;
el = $(this);
attrs = {};
if ( el.is("input[type='checkbox']") )
attrs[el.attr("name")] = el.prop('checked');
else
attrs[el.attr("name")] = el.val();
return model.set(attrs);
});
}

});
}
});
})(jQuery);
})(jQuery);