Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): specify operating system #27

Closed
wants to merge 1 commit into from

Conversation

KishanBagaria
Copy link
Contributor

This makes sure yarn/npm stops early before trying to build and install on non-macOS platforms.

The platform "linux" is incompatible with this module.
The platform "win32" is incompatible with this module.

@codebytere codebytere changed the title package.json: specify os chore(deps): specify operating system Jul 13, 2021
@codebytere
Copy link
Owner

Oops, looks like there's a CI incompatibility error from a commit i pushed a bit back 🤔 i'll take a look but it's not a blocker for this PR so i'll poke at it but i'll merge this PR if i can't figure it out before long since it's fully unrelated to this

@mcmxcdev
Copy link

Just came across this while running into an issue where windows because it is running node-mac-permissions, which it shouldn't even run...

So this PR is highly appreciated if it would get merged and deployed as new release!

@mmaietta
Copy link

This PR might make PR #24 no longer needed

@vraravam
Copy link

@codebytere - its been close to 2 months since your last comment, can we please get this merged soon?

@codebytere codebytere deleted the branch codebytere:master November 11, 2021 18:14
@codebytere codebytere closed this Nov 11, 2021
@vraravam
Copy link

@codebytere - this is causing a lot of issues for us. Can you please merge the PR and release a new version?

@vraravam
Copy link

@KishanBagaria - or, you could raise a new PR against the main branch?

@vraravam
Copy link

vraravam commented Dec 3, 2021

@codebytere - can you please merge the changes from this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants