Skip to content

Updated Formatter for better metrics #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated Formatter for better metrics #12

wants to merge 1 commit into from

Conversation

shetty-tejas
Copy link

Re-opened the previous PR: #7.

I was making a Github Actions project for working with SimpleCov. Turns out this being the recommended gem by SimpleCov, didn't have some functionalities I was thinking of adding support for. So added it here in this PR. If you have any thoughts or suggestions do let me know 😄

What's Changed:

  • Minimum Coverage Check for file. If fails, the file name and the percent_covered is collected in errors.
  • Groups now contain more information such as covered_lines, missed_lines and total_lines.
  • Also returns config details like minimum_coverage and minimum_coverage_by_file.
  • Total metrics as default (even when groups are not available).

@shetty-tejas shetty-tejas force-pushed the master branch 2 times, most recently from f9df56c to d0c8e8d Compare May 21, 2025 12:42
@shetty-tejas
Copy link
Author

@pboling @f-moya Any changes you guys would like me to integrate?

@pboling pboling mentioned this pull request Jul 1, 2025
Open
pboling
pboling approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pboling
Copy link
Contributor

pboling commented Jul 16, 2025

Ping @f-moya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@pboling pboling pboling approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shetty-tejas @pboling