[feat] Enable pagination for AI enabled repos #1101

rohitvinnakota-codecov · 2025-01-15T20:58:30Z

Updates the current repositories resolver that supports pagination for Codecov AI enabled repos. The UI will be updated to use this updated resolver(and support pagination), after which we can safely delete the old non-paginated resolver.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov · 2025-01-15T21:10:23Z

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.05%. Comparing base (ade58e2) to head (82bbbc9).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
graphql_api/actions/repository.py	90.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
- Coverage   96.06%   96.05%   -0.01%     
==========================================
  Files         836      836              
  Lines       19733    19751      +18     
==========================================
+ Hits        18956    18972      +16     
- Misses        777      779       +2

Flag	Coverage Δ
unit	`95.91% <90.90%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2025-01-15T21:10:41Z

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

codecov-notifications · 2025-01-15T21:13:27Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
872	2	870	1

View the top 2 failed test(s) by shortest run time

graphql_api/tests/test_owner.py::TestOwnerType::test_fetch_available_plans_is_enterprise_plan

Stack Traces | 0.407s run time

self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_fetch_available_plans_is_enterprise_plan>

    def test_fetch_available_plans_is_enterprise_plan(self):
        current_org = OwnerFactory(
            username="random-plan-user",
            service="github",
            plan=DEFAULT_FREE_PLAN,
        )
    
        query = """{
            owner(username: "%s") {
                availablePlans {
                    value
                    isEnterprisePlan
                    isProPlan
                    isTeamPlan
                    isSentryPlan
                    isFreePlan
                    isTrialPlan
                }
            }
        }
        """ % (current_org.username)
        data = self.gql_request(query, owner=current_org)
>       assert data == {
            "owner": {
                "availablePlans": [
                    {
                        "value": "users-pr-inappm",
                        "isEnterprisePlan": False,
                        "isProPlan": True,
                        "isTeamPlan": False,
                        "isSentryPlan": False,
                        "isFreePlan": False,
                        "isTrialPlan": False,
                    },
                    {
                        "value": "users-pr-inappy",
                        "isEnterprisePlan": False,
                        "isProPlan": True,
                        "isTeamPlan": False,
                        "isSentryPlan": False,
                        "isFreePlan": False,
                        "isTrialPlan": False,
                    },
                    {
                        "value": "users-teamm",
                        "isEnterprisePlan": False,
                        "isProPlan": False,
                        "isTeamPlan": True,
                        "isSentryPlan": False,
                        "isFreePlan": False,
                        "isTrialPlan": False,
                    },
                    {
                        "value": "users-teamy",
                        "isEnterprisePlan": False,
                        "isProPlan": False,
                        "isTeamPlan": True,
                        "isSentryPlan": False,
                        "isFreePlan": False,
                        "isTrialPlan": False,
                    },
                    {
                        "value": DEFAULT_FREE_PLAN,
                        "isEnterprisePlan": False,
                        "isProPlan": False,
                        "isTeamPlan": True,
                        "isSentryPlan": False,
                        "isFreePlan": True,
                        "isTrialPlan": False,
                    },
                ]
            }
        }
E       AssertionError: assert {'owner': {'a...False, ...}]}} == {'owner': {'a...False, ...}]}}
E         
E         Differing items:
E         {'owner': {'availablePlans': [{'isEnterprisePlan': False, 'isFreePlan': True, 'isProPlan': False, 'isSentryPlan': Fals...Plan': False, ...}, {'isEnterprisePlan': False, 'isFreePlan': False, 'isProPlan': False, 'isSentryPlan': False, ...}]}} != {'owner': {'availablePlans': [{'isEnterprisePlan': False, 'isFreePlan': False, 'isProPlan': True, 'isSentryPlan': Fals...yPlan': False, ...}, {'isEnterprisePlan': False, 'isFreePlan': True, 'isProPlan': False, 'isSentryPlan': False, ...}]}}
E         Use -v to get more diff

graphql_api/tests/test_owner.py:1145: AssertionError

graphql_api/tests/test_owner.py::TestOwnerType::test_owner_available_plans

Stack Traces | 0.503s run time

self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_owner_available_plans>

    @freeze_time("2023-06-19")
    def test_owner_available_plans(self):
        current_org = OwnerFactory(
            username="random-plan-user-123",
            service="github",
            plan=PlanName.CODECOV_PRO_MONTHLY.value,
            pretrial_users_count=123,
        )
        query = """{
            owner(username: "%s") {
                availablePlans {
                    value
                }
            }
        }
        """ % (current_org.username)
        data = self.gql_request(query, owner=current_org)
>       assert data["owner"]["availablePlans"] == [
            {"value": "users-pr-inappm"},
            {"value": "users-pr-inappy"},
            {"value": "users-teamm"},
            {"value": "users-teamy"},
            {"value": DEFAULT_FREE_PLAN},
        ]
E       AssertionError: assert [{'value': 'u...s-pr-inappy'}] == [{'value': 'u...s-developer'}]
E         
E         At index 0 diff: {'value': 'users-teamm'} != {'value': 'users-pr-inappm'}
E         Use -v to get more diff

graphql_api/tests/test_owner.py:688: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

rohitvinnakota-codecov · 2025-01-29T20:05:35Z

@codecov-ai-reviewer review2

sentry-autofix · 2025-01-29T20:05:43Z

On it! We are reviewing the PR and will provide feedback shortly.

rohitvinnakota-codecov · 2025-01-30T19:23:44Z

@codecov-ai-reviewer review2

sentry-autofix · 2025-01-30T19:23:59Z

On it! We are reviewing the PR and will provide feedback shortly.

graphql_api/tests/test_owner.py

graphql_api/types/owner/owner.graphql

rohitvinnakota-codecov · 2025-02-03T14:47:01Z

@codecov-ai-reviewer review2

sentry-autofix · 2025-02-03T14:47:22Z

On it! We are reviewing the PR and will provide feedback shortly.

sentry-autofix · 2025-02-03T14:47:42Z

No changes requiring review at this time.

sentry-autofix · 2025-02-03T14:47:53Z

No changes requiring review at this time.

rohitvinnakota-codecov · 2025-02-03T20:38:34Z

@codecov-ai-reviewer review2

sentry-autofix · 2025-02-03T21:32:01Z

Sentry has generated a new PR with unit tests for this PR. View the new PR(#1126) to review the changes.

rohitvinnakota-codecov · 2025-02-03T23:05:38Z

@codecov-ai-reviewer review2

sentry-autofix · 2025-02-03T23:06:28Z

No changes requiring review at this time.

rohitvinnakota-codecov · 2025-02-04T00:47:17Z

@codecov-ai-reviewer review2

codecov-ai · 2025-02-04T00:47:37Z

On it! We are reviewing the PR and will provide feedback shortly.

graphql_api/tests/test_owner.py

codecov-ai · 2025-02-13T17:39:39Z

No changes requiring review at this time.

…v/codecov-api into rvinnakota/update-ai-repo

codecov-public-qa · 2025-02-18T23:43:48Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
872	2	870	1

View the top 2 failed tests by shortest run time

graphql_api/tests/test_owner.py::TestOwnerType::test_fetch_available_plans_is_enterprise_plan

Stack Traces | 0.407s run time

self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_fetch_available_plans_is_enterprise_plan>

    def test_fetch_available_plans_is_enterprise_plan(self):
        current_org = OwnerFactory(
            username="random-plan-user",
            service="github",
            plan=DEFAULT_FREE_PLAN,
        )
    
        query = """{
            owner(username: "%s") {
                availablePlans {
                    value
                    isEnterprisePlan
                    isProPlan
                    isTeamPlan
                    isSentryPlan
                    isFreePlan
                    isTrialPlan
                }
            }
        }
        """ % (current_org.username)
        data = self.gql_request(query, owner=current_org)
>       assert data == {
            "owner": {
                "availablePlans": [
                    {
                        "value": "users-pr-inappm",
                        "isEnterprisePlan": False,
                        "isProPlan": True,
                        "isTeamPlan": False,
                        "isSentryPlan": False,
                        "isFreePlan": False,
                        "isTrialPlan": False,
                    },
                    {
                        "value": "users-pr-inappy",
                        "isEnterprisePlan": False,
                        "isProPlan": True,
                        "isTeamPlan": False,
                        "isSentryPlan": False,
                        "isFreePlan": False,
                        "isTrialPlan": False,
                    },
                    {
                        "value": "users-teamm",
                        "isEnterprisePlan": False,
                        "isProPlan": False,
                        "isTeamPlan": True,
                        "isSentryPlan": False,
                        "isFreePlan": False,
                        "isTrialPlan": False,
                    },
                    {
                        "value": "users-teamy",
                        "isEnterprisePlan": False,
                        "isProPlan": False,
                        "isTeamPlan": True,
                        "isSentryPlan": False,
                        "isFreePlan": False,
                        "isTrialPlan": False,
                    },
                    {
                        "value": DEFAULT_FREE_PLAN,
                        "isEnterprisePlan": False,
                        "isProPlan": False,
                        "isTeamPlan": True,
                        "isSentryPlan": False,
                        "isFreePlan": True,
                        "isTrialPlan": False,
                    },
                ]
            }
        }
E       AssertionError: assert {'owner': {'a...False, ...}]}} == {'owner': {'a...False, ...}]}}
E         
E         Differing items:
E         {'owner': {'availablePlans': [{'isEnterprisePlan': False, 'isFreePlan': True, 'isProPlan': False, 'isSentryPlan': Fals...Plan': False, ...}, {'isEnterprisePlan': False, 'isFreePlan': False, 'isProPlan': False, 'isSentryPlan': False, ...}]}} != {'owner': {'availablePlans': [{'isEnterprisePlan': False, 'isFreePlan': False, 'isProPlan': True, 'isSentryPlan': Fals...yPlan': False, ...}, {'isEnterprisePlan': False, 'isFreePlan': True, 'isProPlan': False, 'isSentryPlan': False, ...}]}}
E         Use -v to get more diff

graphql_api/tests/test_owner.py:1145: AssertionError

graphql_api/tests/test_owner.py::TestOwnerType::test_owner_available_plans

Stack Traces | 0.503s run time

self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_owner_available_plans>

    @freeze_time("2023-06-19")
    def test_owner_available_plans(self):
        current_org = OwnerFactory(
            username="random-plan-user-123",
            service="github",
            plan=PlanName.CODECOV_PRO_MONTHLY.value,
            pretrial_users_count=123,
        )
        query = """{
            owner(username: "%s") {
                availablePlans {
                    value
                }
            }
        }
        """ % (current_org.username)
        data = self.gql_request(query, owner=current_org)
>       assert data["owner"]["availablePlans"] == [
            {"value": "users-pr-inappm"},
            {"value": "users-pr-inappy"},
            {"value": "users-teamm"},
            {"value": "users-teamy"},
            {"value": DEFAULT_FREE_PLAN},
        ]
E       AssertionError: assert [{'value': 'u...s-pr-inappy'}] == [{'value': 'u...s-developer'}]
E         
E         At index 0 diff: {'value': 'users-teamm'} != {'value': 'users-pr-inappm'}
E         Use -v to get more diff

graphql_api/tests/test_owner.py:688: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

graphql_api/actions/repository.py

…innakota/update-ai-repo

…v/codecov-api into rvinnakota/update-ai-repo

ajay-sentry

lgtm thanks for fixing those weird tests

Initial commit

0cb9d29

codecov deleted a comment from sentry-autofix bot Jan 30, 2025

sentry-autofix bot reviewed Jan 30, 2025

View reviewed changes

graphql_api/tests/test_owner.py Outdated Show resolved Hide resolved

sentry-autofix bot reviewed Jan 30, 2025

View reviewed changes

graphql_api/tests/test_owner.py Outdated Show resolved Hide resolved

sentry-autofix bot reviewed Jan 30, 2025

View reviewed changes

graphql_api/types/owner/owner.graphql Outdated Show resolved Hide resolved

Adal3n3 mentioned this pull request Feb 3, 2025

[Discovery] AI Bot reviewer triggering codecov/engineering-team#3231

Closed

codecov deleted a comment from sentry-autofix bot Feb 3, 2025

sentry-autofix bot mentioned this pull request Feb 3, 2025

Add Tests for PR#1101 #1126

Closed

codecov deleted a comment from sentry-autofix bot Feb 3, 2025

codecov-ai bot reviewed Feb 4, 2025

View reviewed changes

graphql_api/tests/test_owner.py Outdated Show resolved Hide resolved

codecov-ai bot reviewed Feb 4, 2025

View reviewed changes

graphql_api/tests/test_owner.py Outdated Show resolved Hide resolved

rohitvinnakota-codecov and others added 8 commits February 18, 2025 12:51

Update tests

91fd9cd

Update

d047c5b

Merge branch 'main' into rvinnakota/update-ai-repo

f8e566c

Update

7111b1b

Merge branch 'rvinnakota/update-ai-repo' of https://github.com/codeco…

87c2414

…v/codecov-api into rvinnakota/update-ai-repo

Lint

4601365

Update return type

333ff4c

CI headaches

3763fb7

rohitvinnakota-codecov marked this pull request as ready for review February 18, 2025 18:16

rohitvinnakota-codecov requested a review from a team as a code owner February 18, 2025 18:16

rohitvinnakota-codecov force-pushed the rvinnakota/update-ai-repo branch 2 times, most recently from de9135a to 051b12d Compare February 20, 2025 16:05

Try new approach

d987ef7

rohitvinnakota-codecov force-pushed the rvinnakota/update-ai-repo branch from 051b12d to d987ef7 Compare February 20, 2025 16:10

ajay-sentry reviewed Feb 20, 2025

View reviewed changes

graphql_api/actions/repository.py Outdated Show resolved Hide resolved

rohitvinnakota-codecov and others added 9 commits February 20, 2025 14:36

Tests

de1f3de

Merge branch 'main' of https://github.com/codecov/codecov-api into rv…

30dfe70

…innakota/update-ai-repo

Undo

1ef6d08

Sort

4dd984d

Update params

c0fd454

Merge branch 'main' into rvinnakota/update-ai-repo

a54ff4f

Try fix flakes

662df84

Merge branch 'rvinnakota/update-ai-repo' of https://github.com/codeco…

2404b9d

…v/codecov-api into rvinnakota/update-ai-repo

Update tests

0c82122

rohitvinnakota-codecov force-pushed the rvinnakota/update-ai-repo branch from e7f684e to 0c82122 Compare February 21, 2025 14:00

lint

82bbbc9

rohitvinnakota-codecov deployed to staging February 21, 2025 16:29 — with GitHub Actions Active

ajay-sentry approved these changes Feb 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat] Enable pagination for AI enabled repos #1101

[feat] Enable pagination for AI enabled repos #1101

rohitvinnakota-codecov commented Jan 15, 2025 •

edited

Loading

codecov bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025

codecov-notifications bot commented Jan 15, 2025 •

edited by codecov-staging bot

Loading

rohitvinnakota-codecov commented Jan 29, 2025

sentry-autofix bot commented Jan 29, 2025

rohitvinnakota-codecov commented Jan 30, 2025

sentry-autofix bot commented Jan 30, 2025

rohitvinnakota-codecov commented Feb 3, 2025

sentry-autofix bot commented Feb 3, 2025

sentry-autofix bot commented Feb 3, 2025

sentry-autofix bot commented Feb 3, 2025

rohitvinnakota-codecov commented Feb 3, 2025

sentry-autofix bot commented Feb 3, 2025

rohitvinnakota-codecov commented Feb 3, 2025

sentry-autofix bot commented Feb 3, 2025

rohitvinnakota-codecov commented Feb 4, 2025

codecov-ai bot commented Feb 4, 2025

codecov-ai bot commented Feb 13, 2025

codecov-public-qa bot commented Feb 18, 2025 •

edited

Loading

ajay-sentry left a comment

[feat] Enable pagination for AI enabled repos #1101

Are you sure you want to change the base?

[feat] Enable pagination for AI enabled repos #1101

Conversation

rohitvinnakota-codecov commented Jan 15, 2025 • edited Loading

Legal Boilerplate

codecov bot commented Jan 15, 2025 • edited Loading

Codecov Report

github-actions bot commented Jan 15, 2025

codecov-notifications bot commented Jan 15, 2025 • edited by codecov-staging bot Loading

❌ 2 Tests Failed:

rohitvinnakota-codecov commented Jan 29, 2025

sentry-autofix bot commented Jan 29, 2025

rohitvinnakota-codecov commented Jan 30, 2025

sentry-autofix bot commented Jan 30, 2025

rohitvinnakota-codecov commented Feb 3, 2025

sentry-autofix bot commented Feb 3, 2025

sentry-autofix bot commented Feb 3, 2025

sentry-autofix bot commented Feb 3, 2025

rohitvinnakota-codecov commented Feb 3, 2025

sentry-autofix bot commented Feb 3, 2025

rohitvinnakota-codecov commented Feb 3, 2025

sentry-autofix bot commented Feb 3, 2025

rohitvinnakota-codecov commented Feb 4, 2025

codecov-ai bot commented Feb 4, 2025

codecov-ai bot commented Feb 13, 2025

codecov-public-qa bot commented Feb 18, 2025 • edited Loading

❌ 2 Tests Failed:

ajay-sentry left a comment

Choose a reason for hiding this comment

rohitvinnakota-codecov commented Jan 15, 2025 •

edited

Loading

codecov bot commented Jan 15, 2025 •

edited

Loading

codecov-notifications bot commented Jan 15, 2025 •

edited by codecov-staging bot

Loading

codecov-public-qa bot commented Feb 18, 2025 •

edited

Loading