Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile changes for monorepo prep #1165

Merged
merged 1 commit into from
Feb 20, 2025
Merged

makefile changes for monorepo prep #1165

merged 1 commit into from
Feb 20, 2025

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Feb 19, 2025

needed for https://github.com/codecov/umbrella/pull/4

we bindmount our local codecov-api into the docker container. currently our local codecov-api is the actual git repo, so the git invocation works. in umbrella, it's not the actual git repo, so the command fails

apparently this is all i need to change...?

@matt-codecov matt-codecov marked this pull request as draft February 19, 2025 23:59
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (015b940) to head (a0aa237).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1165   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         836      836           
  Lines       19723    19723           
=======================================
  Hits        18948    18948           
  Misses        775      775           
Flag Coverage Δ
unit 95.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-codecov matt-codecov requested a review from a team February 20, 2025 02:41
@matt-codecov matt-codecov marked this pull request as ready for review February 20, 2025 02:41
Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, wouldnt this be hinting at the left side of the statement having some issue? But it works?

@matt-codecov
Copy link
Contributor Author

copied from codecov/worker#1097 (comment):

until recently (codecov/gha-workflows#42) we invoked the CLI inside the container which uses git for a few things. we no longer do that, but i tried to delete this line and it fatally failed. honestly don't know why but i am reasonably confident that it doesn't matter so i ignore the failure here

@matt-codecov matt-codecov added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit cfb316b Feb 20, 2025
28 checks passed
@matt-codecov matt-codecov deleted the pr1165 branch February 20, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants