Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

components over time display name instead of id #2855

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

components over time display name instead of id #2855

wants to merge 4 commits into from

Conversation

JerrySentry
Copy link
Contributor

@JerrySentry JerrySentry commented May 7, 2024 •
edited
Loading

fixes: codecov/engineering-team#1702

The components table now displays component name instead of ID. This also fixes linking to the code tree view via clicking on the component names on the table

Screenshot 2024-05-07 at 4 09 43 PM
Screenshot 2024-05-07 at 4 09 54 PM

The codecov.yml file looks like this for components. Notice that the name is being displayed now, and "banker" has no name so the ID is showing.

  individual_components:
    - component_id: dictionary
      name: DictionaryApp
      paths:
        - "**/dictionary.py"
    - component_id: calculator
      name: CalculatorApp
      paths:
        - "**/calculator.py"
      flag_regexes:
        - "unit"
    - component_id: banker
      paths:
        - "**/banker.py"
      flag_regexes:
        - "integration"

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented May 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (0704cb9) to head (d490b8c).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2855   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         875      875           
  Lines       12914    12916    +2     
  Branches     3397     3458   +61     
=======================================
+ Hits        12718    12720    +2     
  Misses        192      192           
  Partials        4        4
Files Coverage Δ
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.83% <100.00%> (+0.05%) ⬆️
...able/DeleteComponentModal/DeleteComponentModal.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoComponents.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.27% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0704cb9...d490b8c. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (0704cb9) to head (d490b8c).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2855   +/-   ##
=====================================
  Coverage   98.48   98.48           
=====================================
  Files        875     875           
  Lines      12914   12916    +2     
  Branches    3457    3463    +6     
=====================================
+ Hits       12718   12720    +2     
  Misses       192     192           
  Partials       4       4
Files Coverage Δ
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.83% <100.00%> (+0.05%) ⬆️
...able/DeleteComponentModal/DeleteComponentModal.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoComponents.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.27% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0704cb9...d490b8c. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented May 7, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 141 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.58MB 141 bytes ⬆️

@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 141 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.58MB 141 bytes ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented May 7, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
b15fa49 Tue, 07 May 2024 17:04:01 GMT Expired Expired
681f0d7 Tue, 07 May 2024 18:04:47 GMT Expired Expired
bd8f136 Thu, 09 May 2024 16:17:52 GMT Expired Expired
d490b8c Thu, 09 May 2024 17:30:11 GMT Cloud Enterprise

@codecov-public-qa Codecov Public QA
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (0704cb9) to head (d490b8c).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2855   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         875      875           
  Lines       12914    12916    +2     
  Branches     3396     3458   +62     
=======================================
+ Hits        12718    12720    +2     
  Misses        192      192           
  Partials        4        4
Files Coverage Δ
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.83% <100.00%> (+0.05%) ⬆️
...able/DeleteComponentModal/DeleteComponentModal.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoComponents.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.27% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0704cb9...d490b8c. Read the comment docs.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2855   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         875      875           
  Lines       12914    12916    +2     
  Branches     3462     3440   -22     
=======================================
+ Hits        12718    12720    +2     
  Misses        192      192           
  Partials        4        4
Files Coverage Δ
...tsTab/subroute/ComponentsTable/ComponentsTable.tsx 95.83% <100.00%> (+0.05%) ⬆️
...able/DeleteComponentModal/DeleteComponentModal.tsx 100.00% <100.00%> (ø)
src/services/repo/useRepoComponents.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 54.54% <ø> (ø)
Layouts 97.26% <ø> (ø)
Pages 99.27% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0704cb9...d490b8c. Read the comment docs.

@JerrySentry JerrySentry enabled auto-merge May 9, 2024 18:22
@JerrySentry JerrySentry disabled auto-merge May 9, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-sentry ajay-sentry ajay-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug when clicking on a component in the table doesn't link correctly to the code tree
3 participants
@JerrySentry @codecov-releaser @ajay-sentry