Add Elixir-specific note on System.find_executable in base-07-mg5.md #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to @itissid for highlighting the issue! |
|
@andy1li Thanks! I think a general improvement to most exercises would be to add something like:
|
rohitpaulk
requested changes
Aug 15, 2025
| @@ -8,6 +8,10 @@ For example, if PATH is `/dir1:/dir2:/dir3`, your shell should search in `/dir1` | |||
| - If a matching files is found and it has execute permissions, your shell should print the path to the file. | |||
| - If no matching files are found, your shell should print `<command>: not found`. | |||
|
|
|||
| {{#lang_is_elixir}} | |||
There was a problem hiding this comment.
- Let's move this to the notes section
- Let's add a fallback case for a generic language
- We don't have to say it's not recommended - a shell would usually use this, so it's okay.
For Elixir, you could say something like:
You can either use System.find_executable or implement the PATH traversal logic on your own.
For others, could be something like:
Most programming languages have methods in their standard library that can help with PATH traversal. For example, xyz in Python and in Go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
https://secure.helpscout.net/conversation/draft/3036133345/9279