Integrate pdf complexity into application#121
Merged
Conversation
Contributor
|
This seems really great to me! I don't have any critical feedback. How would you feel about adding a little test coverage for the new filter to our rspec tests? Somewhere in this test might make sense. I'd also be happy to do it in a followup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses ASAP-136. Adds simple / complex labels onto documents and allows the user to filter by them.
Two outstanding questions for feedback:
(1) Would adding this as a column to the main list view be helpful? We could add a hover over to explain how we constructed this score.
(2) What should the default behavior be called? I struggled with following other conventions (e.g., from "Document Type" -> "All Types", to "Complexity" -> "All Complexities" felt too wordy).