Skip to content

fix: Fix validate destination 3 1 5 #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
Merged

fix: Fix validate destination 3 1 5 #440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0657778
chore: sync all codefresh code changes into v3.0.2 without event-repo…
oleksandr-codefresh May 16, 2025
65558c0
fix validateDestination
ppapapetrou76 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions server/application/application_validate_src_and_dest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ import (
"errors"
"fmt"

"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
apierrors "k8s.io/apimachinery/pkg/api/errors"

"github.com/argoproj/argo-cd/v3/pkg/apiclient/application"
Expand Down Expand Up @@ -73,22 +71,5 @@ func validateDestination(ctx context.Context, dest *appv1.ApplicationDestination
return errors.New("no destination defined in app spec")
}
_, err := argo.GetDestinationCluster(ctx, *dest, db)
if err != nil {
return err
}

if dest.Server != "" {
// Ensure the k8s cluster the app is referencing, is configured in Argo CD
_, err := db.GetCluster(ctx, dest.Server)
if err != nil {
if errStatus, ok := status.FromError(err); ok && errStatus.Code() == codes.NotFound {
return fmt.Errorf("cluster '%s' has not been configured", dest.Server)
}
return err
}
} else if dest.Server == "" {
return errors.New("destination server missing from app spec")
}

return nil
return err
}
Loading