feat: Add multi-arch add-clusters image #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacamposol
requested review from
danielm-codefresh,
roi-codefresh,
itai-codefresh,
noam-codefresh,
pasha-codefresh and
ziv-codefresh
as code owners
dacamposol
force-pushed
the
main
branch
2 times, most recently
from
57bda11 to
7446624
Compare
Signed-off-by: Daniel Campos Olivares <[email protected]>
* Up version * Up version * Up proxy version * Wip * Back version * Wip
* add applications to app-proxy rbac * bump * remove version bump
* add initContainer to app-proxy
Co-authored-by: Daniel Maizel <[email protected]>
* fix appset * fix hosted installation * fix hybrid install * argocd 2.4 install * Debug * Revert "Debug" This reverts commit c02c9af. Co-authored-by: danielm-codefresh <[email protected]>
* bump app-proxy to 1.1991.1
app proxy update
* Revert "move hosted to 2.4 (codefresh-io#129)" This reverts commit 22f5ef5. * Revert "fix appset (codefresh-io#133)" This reverts commit aeeeb3a. * fix
* update app-proxy * hybrid test * Revert "hybrid test" This reverts commit e656ba8.
* Release 0.1.16 (codefresh-io#134) releasing 0.1.16 * Revert "Revert hosted move to argocd 2.4 (codefresh-io#139)" This reverts commit b63acd3 * hosted 2.4 * hosted 2.4 * runtime.yaml * fix hybrid * fix hybrid * revert VERSION Co-authored-by: Daniel Maizel <[email protected]>
* =upgrade argo-workflows * fix changed ns * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * prepare for merge * wip * prepare for merge * update tag to 3.4.4
* mount argocd-token to app-proxy env * bumped app-proxy to 1.2016.2 Co-authored-by: Noam Gal <[email protected]> Co-authored-by: andrii-codefresh <[email protected]>
argo-cd version update with rollback query
This reverts commit ce2330b.
* Revert "Revert "upgrade argo-workflows to 3.4 (codefresh-io#144)"" * add namespace override for argo-workflows Co-authored-by: danielm-codefresh <[email protected]>
…defresh-io#158) * automatically merge release branch to main * add component version to release notes
* bump app-proxy * bump * trigger * trigger * bump * remove redundent bump
change back to argocd user/password instead of token
…defresh-io#163) * readme * add permissions for app-proxy to read, list and patch deployments
* new rollouts version * update rollouts
danielm-codefresh
force-pushed
the
main
branch
from
487ab8c to
bcdef74
Compare
danielm-codefresh
requested review from
daniel-codefresh,
denis-codefresh and
yaroslav-codefresh
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In the original image,
bitnami/kubectlis being used as base, which only exists in the Docker Registry inamd64architecture as thekubectlbinary is only available in that architecture.Currently, and since Kubernetes 1.24; it's normal to find more and more ARM-based Kubernetes nodes, and the current
add-clusterscript won't work to set up these (the spawned Pod from the Job will fail stating the mismatch between architectures), provoking a sense of cumbersome setup to the cluster administrator. This caveats have an easy solution, as the Kubernetes CLI has been already provided inarm64version for a while.Solution
Since I faced the previously mentioned problems on the setup of my cluster in CodeFresh, I created a custom image which uses the script defined in this repo (
add-cluster.sh) but usingbitnami/minidebas base (available in bothamd64andarm64architectures).That image is the one that I'm proposing to include in the official repository.
Why the PR?
In order to use custom images, I required to run the
cf cluster add codefresh-hosted --dry-runcommand and to manually modify the image used in the Job.I think that offering an official multi-arch image would be better and would improve the onboarding process for those who have Kubernetes Clusters with ARM nodes.
PS: Additionally, the proposed Dockerfile has less vulnerabilities than the official image by
bitnami/kubectl, having this one only low severity vulnerabilities while thebitnami/kubectlone has some high and medium severity vulnerabilities.