feat: add gitops-operator-default pulling interval #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarbis
reviewed
Apr 22, 2025
| @@ -662,7 +662,9 @@ gitops-operator: | |||
| # -- Additional labels for gitops operator CRDs | |||
| additionalLabels: {} | |||
|
|
|||
| env: {} | |||
| env: { | |||
| TASK_PULLING_INTERVAL: 10s | |||
There was a problem hiding this comment.
I think we are looking for POLLING term
There was a problem hiding this comment.
yeah, at the moment the field is task-pulling-interval, and by default the env var is TASK_PULLING_INTERVAL
in a pr i am currently working on, i fixed the field + env var to use "polling". once i merge it, i will make sure to also update the env var in gitops-runtime-helm accordingly.
There was a problem hiding this comment.
yeah I just had to match the current value, @ATGardner if you can put your self some note to fix it in the next runtime
zarbis
approved these changes
Apr 22, 2025
ATGardner
reviewed
Apr 22, 2025
Comment on lines
79
to
82
| {{/* Set DEFAULT_TASK_PULLING_INTERVAL */}} | ||
| {{- if not (index .Values "gitops-operator").env.TASK_PULLING_INTERVAL }} | ||
| {{- $_ := set $gitopsOperatorContext.Values.env "TASK_PULLING_INTERVAL" "10s" }} | ||
| {{- end }} |
There was a problem hiding this comment.
do we need this template bit?
wouldn't just adding it to the values.yaml under gitops-operator.env be enough to set it as a default value?
ATGardner
approved these changes
Apr 22, 2025
eti-codefresh
approved these changes
Apr 22, 2025
dmaizel
approved these changes
Apr 22, 2025
|
/e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Notes