Skip to content

feat: add Argo CD version check and validation in pre-install hook #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: add Argo CD version check and validation in pre-install hook #462

wants to merge 7 commits into from

Conversation

ATGardner
Copy link
Contributor

make sure argo-cd is >=2.12 and <3

What

Why

Notes

@ATGardner ATGardner requested review from a team as code owners April 25, 2025 08:13
@ATGardner ATGardner self-assigned this Apr 25, 2025
zarbis
zarbis reviewed Apr 25, 2025
View reviewed changes
charts/gitops-runtime/templates/hooks/pre-install/validate-values.yaml Outdated
args:
- cf helm validate --values /job_tmp/values.yaml --namespace ${NAMESPACE} --version ${VERSION} --hook --log-level debug
args:
- |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use VSCode I advise using YAML Embedded Languages languages extension and adding language comment - makes it easier on eyes.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a nice trick. i installed the extension, and added the comment.

Copy link
Contributor

@zarbis zarbis Apr 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

You can also run this code like so: cat argo-platform/merge-queue.yaml | yq '.steps.wait_for_previous_promotion.commands[0]' | bash. Although figuring out variables passed to the script is tricky.

@ATGardner
Copy link
Contributor Author

build fails because of the size of the new image.
i added nodejs + npm, just so i can install the global package of "semver". i now checked on my computer - that bumped the image size from 294MB to 1.06GB.
is there some simpler (smaller) way to make a semver range check? i can do it all in bash. it is managable for hard-coded ">=2.12 <3", but for a more generic range-check string it will quickly become a pain.

@zarbis
Copy link
Contributor

zarbis commented Apr 25, 2025 •
edited
Loading

build fails because of the size of the new image. i added nodejs + npm, just so i can install the global package of "semver". i now checked on my computer - that bumped the image size from 294MB to 1.06GB. is there some simpler (smaller) way to make a semver range check? i can do it all in bash. it is managable for hard-coded ">=2.12 <3", but for a more generic range-check string it will quickly become a pain.

Check this out. I use it for this very repo's lifecycle.

@ATGardner
Copy link
Contributor Author

build fails because of the size of the new image. i added nodejs + npm, just so i can install the global package of "semver". i now checked on my computer - that bumped the image size from 294MB to 1.06GB. is there some simpler (smaller) way to make a semver range check? i can do it all in bash. it is managable for hard-coded ">=2.12 <3", but for a more generic range-check string it will quickly become a pain.

Check this out. I use it for this very repo's lifecycle.

thanks. I'll give it a go

@ATGardner
Copy link
Contributor Author

ATGardner commented Apr 26, 2025 •
edited
Loading

i switched over to use the semver-cli. on my machine, the image is now 300MB, which seems fine to me.
but ci still fails with

error: failed to solve: ResourceExhausted: failed to prepare sha256:127f85cd6ab879a998cb8f434ea30441d104e611c3641ddda966f6911edc9ee5 as k6bvh2yxdcq99isg5xdan8kwz: copying of parent failed: failed to copy files: write /home/user/.local/share/buildkit/runc-native/snapshots/snapshots/new-1944281478/usr/local/go/test/fixedbugs/bug245.go: copy_file_range: no space left on device

i suspect this is not directly related to the image size, but maybe to some actual problem we may have in the cluster.

@ATGardner
feat: add Argo CD version check and validation in pre-install hook
5dca0e4 
Enhance the pre-install hook to include a version check for Argo CD.
This change introduces environment variables for Argo CD service discovery
and version validation, ensuring compatibility with the required version
constraint. Additionally, update the Dockerfile to install necessary
dependencies for the validation process.
@ATGardner
added "yaml embedded languages" comment
656980d 
that's a very handy trick, thanks.
@ATGardner
feat: update Argo CD version check to use semver-cli
7ff1f59 
Replace the semver command with semver-cli for version validation in the
pre-install hook. This change ensures compatibility with the latest
versioning standards and improves the reliability of version checks.
@ATGardner
bump
63b1b3f
@ATGardner
fix: update golang version and install additional packages in Dockerfile
bf6573f 
Updated the golang base image to version 1.24.2 and added 'jq' to the
apt-get install command to support JSON processing in subsequent
scripts. This ensures compatibility and enhances functionality.
@ATGardner
feat: enhance Argo CD version check with improved validation logic
2409cb0 
Refactor the Argo CD version check in the pre-install hook to include
additional validation functions. This change introduces a more robust
method for fetching and validating the Argo CD service information
and version, ensuring compliance with specified version constraints.
The configuration options for the version check have also been
streamlined in the values.yaml file.
@ATGardner ATGardner force-pushed the feat/CR-28623-check-argocd-ver branch from f78a7d3 to 2409cb0 Compare April 29, 2025 08:35
@ATGardner
Copy link
Contributor Author

/e2e

@ATGardner
Copy link
Contributor Author

/e2e

1 similar comment
@ATGardner
Copy link
Contributor Author

/e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarbis zarbis zarbis left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ATGardner ATGardner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ATGardner @zarbis