Revert usage of cmd on Windows #109
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel3rd
force-pushed
the
update-41-Revert_usage_of_cmd_on_Windows
branch
from
965bed7 to
6168f2b
Compare
michael-o
requested changes
Dec 21, 2020
src/test/java/org/codehaus/plexus/util/cli/CommandlineTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/codehaus/plexus/util/cli/CommandlineTest.java
Outdated
Show resolved
Hide resolved
axel3rd
force-pushed
the
update-41-Revert_usage_of_cmd_on_Windows
branch
from
6168f2b to
5f9a5ec
Compare
|
Note: GitHub action verify problem with Java 16-ea is not part of this PR. |
|
(@michael-o: Requested changes have been done) |
See #116 |
|
Is this PR (or #110) not relevant 😢 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an update of old previous staling PR #41
cf. #17 (comments from May 2018): Revert the usage of
cmd.exe(on Windows), because prevents the destroy/kill launched by this way whenCTRL+C.For history: This Windows shell specific is removed since plexus-utils 3.0.15, except for 3.1.0.
On Windows, the usage of cmd builtin (like
echo) or.cmd/.baton PATH should be implemented by the client/user.Another approach could be a dedicated option: See #110