Skip to content

refactor: fix phpstan no type specified SaveModelTest #10032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulbalandan merged 2 commits into from
Mar 11, 2026
+2 −9
Merged

refactor: fix phpstan no type specified SaveModelTest #10032

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f815fd4
refactor: fix phpstan no type specified SaveModelTest
adiprsa Mar 10, 2026
6a133f4
remove unused properties
adiprsa Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/system/Models/SaveModelTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ public function testSaveNewEntityWithDate(): void
protected $returnType = 'object';
protected $useSoftDeletes = true;
protected $dateFormat = 'date';
public $name = '';
public string $name = '';
};

$entity->name = 'Mark';
Expand Down
2 changes: 1 addition & 1 deletion utils/phpstan-baseline/loader.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# total 2063 errors
# total 2062 errors

includes:
- argument.type.neon
Expand Down
7 changes: 1 addition & 6 deletions utils/phpstan-baseline/missingType.property.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# total 48 errors
# total 47 errors

parameters:
ignoreErrors:
Expand Down Expand Up @@ -236,8 +236,3 @@ parameters:
message: '#^Property CodeIgniter\\Database\\Live\\MySQLi\\NumberNativeTest\:\:\$tests has no type specified\.$#'
count: 1
path: ../../tests/system/Database/Live/MySQLi/NumberNativeTest.php

-
message: '#^Property CodeIgniter\\Model@anonymous/tests/system/Models/SaveModelTest\.php\:286\:\:\$name has no type specified\.$#'
count: 1
path: ../../tests/system/Models/SaveModelTest.php
Loading