Skip to content

Comments

docs: PHPStan Codeigniter no type specified#7830

Closed
ddevsr wants to merge 2 commits intocodeigniter4:developfrom
ddevsr:codeigniter-system-specified
Closed

docs: PHPStan Codeigniter no type specified#7830
ddevsr wants to merge 2 commits intocodeigniter4:developfrom
ddevsr:codeigniter-system-specified

Conversation

@ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Aug 17, 2023

Description
See #7731

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Co-authored-by: kenjis <kenji.uui@gmail.com>
@kenjis
Copy link
Member

kenjis commented Aug 17, 2023

Ah, PHPStan is correct, but the errors reported.
callExit() will be deprecated in 4.4, so do we remove never for now?

Error: Unreachable statement - code above always terminates.
Error: Unreachable statement - code above always terminates.
Error: Method CodeIgniter\Test\Mock\MockCodeIgniter::callExit() should always throw an exception or terminate script execution but doesn't do that.
 ------ ------------------------------------------------------- 
  Line   system/CodeIgniter.php                                 
 ------ ------------------------------------------------------- 
  368    Unreachable statement - code above always terminates.  
  389    Unreachable statement - code above always terminates.  
 ------ ------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   system/Test/Mock/MockCodeIgniter.php                                 
 ------ --------------------------------------------------------------------- 
  22     Method CodeIgniter\Test\Mock\MockCodeIgniter::callExit() should      
         always throw an exception or terminate script execution but doesn't  
         do that.                                                             
 ------ --------------------------------------------------------------------- 

https://github.com/codeigniter4/CodeIgniter4/actions/runs/5886199394/job/15963712417?pr=7830

@paulbalandan
Copy link
Member

We can leave it as is in the baseline and remove it once 4.4 is released.

@MGatner
Copy link
Member

MGatner commented Aug 20, 2023

So does @ddevsr need to rebase and regenerate the baseline?

@kenjis kenjis added the stale Pull requests with conflicts label Aug 27, 2023
@ddevsr ddevsr closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Pull requests with conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants