Skip to content

Comments

docs: fix PHPStan in Commands#8964

Merged
kenjis merged 4 commits intocodeigniter4:developfrom
ddevsr:phpstan-commands
Jun 19, 2024
Merged

docs: fix PHPStan in Commands#8964
kenjis merged 4 commits intocodeigniter4:developfrom
ddevsr:phpstan-commands

Conversation

@ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Jun 14, 2024

Description
See #7731

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the documentation Pull requests for documentation only label Jun 14, 2024
@kenjis
Copy link
Member

kenjis commented Jun 15, 2024

@ddevsr
I use the label documentation to PRs to change the User Guide.
Do you think it is better to use the label to the PR to doc comments like this?

@github-actions github-actions bot added the stale Pull requests with conflicts label Jun 19, 2024
@github-actions
Copy link

👋 Hi, @ddevsr!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

ddevsr and others added 3 commits June 19, 2024 17:28
@ddevsr ddevsr force-pushed the phpstan-commands branch from 801c7b3 to c2e843f Compare June 19, 2024 10:29
@ddevsr ddevsr removed the stale Pull requests with conflicts label Jun 19, 2024
@ddevsr ddevsr requested a review from kenjis June 19, 2024 10:34
@kenjis kenjis merged commit c8b8995 into codeigniter4:develop Jun 19, 2024
@kenjis
Copy link
Member

kenjis commented Jun 19, 2024

@ddevsr Thank you!

@kenjis kenjis removed the documentation Pull requests for documentation only label Jun 20, 2024
@ddevsr ddevsr deleted the phpstan-commands branch June 20, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants