Replace Scroll API with PIT API in OpenSearch #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace OpenSearch Scroll API with Point in Time (PIT) API across the codebase to improve pagination and performance. Changes: - ESSourceReader: Replace scroll-based pagination with PIT and search_after - SuggestIndexer: Update deleteDocumentWords() and deleteQueryWords() to use PIT - SuggestUtil: Add createPit() and deletePitContext() methods, update deleteByQuery() - SuggestSettings: Replace scrollTimeout with pitKeepAlive - SuggestSettingsBuilder: Replace scrollTimeout() with pitKeepAlive() - Update all test files to use PIT API Benefits of PIT API: - More consistent pagination results - Support for bidirectional pagination - Better handling of concurrent document changes - Not bound to specific queries like Scroll API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace OpenSearch Scroll API with Point in Time (PIT) API across the codebase to improve pagination and performance.
Changes:
Benefits of PIT API: