forked from calcom/cal.com
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/sso pages #166
Open
r4zendev
wants to merge
5
commits into
main
Choose a base branch
from
chore/sso-pages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chore/sso pages #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
r4zendev
force-pushed
the
chore/sso-pages
branch
2 times, most recently
from
January 11, 2024 18:32
e16fcc3
to
961c2a3
Compare
grzpab
reviewed
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
r4zendev
force-pushed
the
chore/sso-pages
branch
4 times, most recently
from
January 18, 2024 16:35
70f056f
to
c5afa8d
Compare
hbjORbj
force-pushed
the
chore/sso-pages
branch
from
January 19, 2024 09:24
c5afa8d
to
4144b82
Compare
> I'm in the core Team of inlang ## Fix inlang's configuration file We changed the `project.inlang.json` to a `settings.json` in a `project.inlang` dir. This enables the inlang project to store app information or metadata in a dir that is not relevant to you as an end user. #### Old ```tree ├── project.inlang.json ``` #### New ```tree ├── project.inlang │ ├── settings.json ```
) Co-authored-by: Benny Joo <[email protected]>
hbjORbj
force-pushed
the
chore/sso-pages
branch
from
January 19, 2024 18:59
4144b82
to
7a6511d
Compare
This PR is being marked as stale due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR migrates the /auth/sso pages to use the app directory (which runs under the App Router).
Migrated page exist under
/future/auth/sso
and is accessible at all times.Type of change
How should this be tested?
Pages performance can be accessed via their individual URLs and various metrics could be validated to be improved compared to the previous implementation.
Mandatory Tasks
Checklist