feat: Add Docker Hub login and push within Docker build actions #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Docker Hub login has been integrated within the Docker build actions in the GitHub workflow for pushing changes. This change eliminates the need of the previous standalone Docker login and logout steps while making build actions to directly push built images to the registry. Signed-off-by: Abdelkader Boudih <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Docker Hub login has been integrated within the Docker build actions in the GitHub workflow for pushing changes. This change eliminates the need of the previous standalone Docker login and logout steps while making build actions to directly push built images to the registry.
Please not that secrets.REGISTRY_USER is still being used in push-dev.yml workflow.