Skip to content

[agent_farm] make context_crunching logs distinct (Run ID: codestoryai_sidecar_issue_2032_63e8c74b)#2033

Merged
theskcd merged 3 commits intomainfrom
codestoryai_sidecar_issue_2032_63e8c74b
Feb 9, 2025
Merged

[agent_farm] make context_crunching logs distinct (Run ID: codestoryai_sidecar_issue_2032_63e8c74b)#2033
theskcd merged 3 commits intomainfrom
codestoryai_sidecar_issue_2032_63e8c74b

Conversation

@theskcd
Copy link
Contributor

@theskcd theskcd commented Feb 9, 2025

agent_instance: codestoryai_sidecar_issue_2032_63e8c74b Tries to fix: #2032

🔧 Logging Enhancement: Differentiated event type metadata for context crunching and tool use flows

  • Modified: Introduced try_with_llm_with_event_type method to support distinct event types
  • Updated: Context crunching now sends context_crunching event type instead of tool_use for better log disambiguation

Ready for review! This change will help improve observability by making it easier to track and analyze different agent behaviors separately.

@theskcd
Copy link
Contributor Author

theskcd commented Feb 9, 2025

/agent hmm smart but the function names are confusing, can we instead just keep the try_with_llm and pass the event_type there instead, I feel thats better and more intuitive
use cargo check to check your work

The commit simplifies try_with_llm by merging it with try_with_llm_with_event_type and making the event_type parameter optional with a default value of "tool_use".
@theskcd
Copy link
Contributor Author

theskcd commented Feb 9, 2025

Enhancement: Streamlined LLM interaction logic in tool_use_agent.rs

  • Consolidated event type handling within the try_with_llm function for improved code clarity and maintainability.
  • Updated call sites and added necessary parameter passing to ensure seamless integration with the revised logic. Please review!

@theskcd
Copy link
Contributor Author

theskcd commented Feb 9, 2025

/agent use cargo check and then cargo fmt

The changes appear to be purely formatting-related, adjusting whitespace, indentation, and line breaks to follow Rust formatting conventions using cargo fmt.
@theskcd
Copy link
Contributor Author

theskcd commented Feb 9, 2025

Code Enhancement: Successfully consolidated LLM interaction logic in tool_use_agent.rs with improved event type handling

  • Modified: Streamlined try_with_llm to accept optional event type parameter (defaulting to "tool_use")
  • Verified: Code compiles successfully with only minor formatting warnings
  • Impact: Better observability through differentiated event type metadata

Ready for review! This change simplifies our codebase while maintaining full functionality. 🔍

@theskcd theskcd merged commit 0c58ee2 into main Feb 9, 2025
3 checks passed
@theskcd theskcd deleted the codestoryai_sidecar_issue_2032_63e8c74b branch February 9, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[agent_farm] make context_crunching logs distinct

1 participant