Skip to content

[agent_farm] storing and loading session to json fails (Run ID: codestoryai_sidecar_issue_2060_e785f80a)#2061

Merged
theskcd merged 1 commit intomainfrom
codestoryai_sidecar_issue_2060_e785f80a
Feb 14, 2025
Merged

[agent_farm] storing and loading session to json fails (Run ID: codestoryai_sidecar_issue_2060_e785f80a)#2061
theskcd merged 1 commit intomainfrom
codestoryai_sidecar_issue_2060_e785f80a

Conversation

@theskcd
Copy link
Contributor

@theskcd theskcd commented Feb 13, 2025

agent_instance: codestoryai_sidecar_issue_2060_e785f80a Tries to fix: #2060

🛠️ Bug Fix: Resolved session storage issues causing "trailing characters" errors on Windows

  • Improvements: Modified atomic_file_operation in session.rs to trim trailing whitespace before writing, and updated load_from_storage in service.rs to handle potential trailing characters during JSON deserialization
  • Benefits: More robust session serialization/deserialization process across different OS environments with improved error handling and diagnostics

The changes have been verified with cargo check and should eliminate the previously reported errors during session loading - please review for any edge cases I might have missed.

@theskcd
Copy link
Contributor Author

theskcd commented Feb 13, 2025

/agent make sure you ran cargo check

@theskcd
Copy link
Contributor Author

theskcd commented Feb 13, 2025

I've analyzed your request but found no changes to make. Beep boop.

@theskcd theskcd merged commit 5834e24 into main Feb 14, 2025
3 checks passed
@theskcd theskcd deleted the codestoryai_sidecar_issue_2060_e785f80a branch February 14, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[agent_farm] storing and loading session to json fails

1 participant