Skip to content

Fix logger #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 15, 2018
Merged

Fix logger #190

merged 8 commits into from
Apr 15, 2018

Conversation

marojenka
Copy link

well there was a missprint in this small and unnecessary QOL change. Oops.
p.s. I thought i merged with master yet all those commits are in thin pull request.

@codecov
Copy link

codecov bot commented Apr 15, 2018

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files           5        5           
  Lines         257      257           
=======================================
  Hits          248      248           
  Misses          9        9
Impacted Files Coverage Δ
stdimage/models.py 95.27% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b02bd5...894d0e2. Read the comment docs.

@codingjoe codingjoe merged commit e762dd1 into codingjoe:master Apr 15, 2018
@codingjoe
Copy link
Owner

Good cat, thanks again!

Released in 3.1.1

@marojenka
Copy link
Author

sadly it is not so good catch rather fixing my mistake, sorry.

marojenka added a commit to marojenka/django-stdimage that referenced this pull request Apr 15, 2018
Fix log statment -- Use __mod__ over format style (codingjoe#190)
@marojenka marojenka deleted the fix-logger branch April 15, 2018 17:25
@codingjoe
Copy link
Owner

@marojenka don't worry. I didn't see it in the review ether and I don't believe plenty people updated before I released the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants